Stuff

Comments

The scripts sets stdin to the file specified as the argument and
executes a loop reading from the file (as stdin).

In the function comments_from_wx(), if $wxfile is not set (as in this case),
the awk command will take its input from stdin, emptying the list.

Entry 1 fred.oliver [2007-06-26 17:42]

SuggestedFix

*** /tmp/webrev.sh      Mon Jun 25 14:36:23 2007
--- /home/foliver/bin/hgwebrev  Tue Jun 26 13:39:09 2007
***************
*** 1120,1125 ****
--- 1120,1128 ----
  #
  comments_from_wx()
  {
+       if [[ -z $wxfile ]]; then
+           return
+       fi
        typeset fmt=$1
        typeset p=$2

Entry 1 fred.oliver [2007-06-26 17:42]

Justification

Priority changed from [] to [3-Medium]
Webrev is broken in common(?) use case.
fred.oliver@sun.com 2007-06-26 17:42:55 GMT