All pastes #487277 Raw Edit

phoemix

public text v1 · immutable
·published 2007-05-14 11:10 UTC
rendered paste body
> hello
>
> if WITHOUT_NVIDIA (or whatever) is set, you define a macro
> WITH_NVIDIA_GL=0, which is generally wrong.
>
> the code checks against the existance of the definition, and not
> against the value of the definition:
>    #ifdef WITH_NVIDIA_GL
>       glXFreeMemoryNV(glx_memory);
>    #elif
>       glXFreeMemoryMESA(dpy, DefaultScreen(dpy), glx_memory);
>    #endif
>
> and if you look closely, you will notice, that the code is
> also wrong, the middle line has to be corrected for "#else".
> it will look like this:
>
>    #ifdef WITH_NVIDIA_GL
>       glXFreeMemoryNV(glx_memory);
>    #else
>       glXFreeMemoryMESA(dpy, DefaultScreen(dpy), glx_memory);
>    #endif
>
> There are two of this at yuvrect_client.c:{145,326}.
>
> Please correct this in graphics/mesa-demos
>
>
>
>
> Bye,
>
> Gergely Czuczy
> mailto: gergely.czuczy@harmless.hu
>