[17:43] <tsdgeos> marktaff: you don't need having @author on each function :D
[17:43] <marktaff> tsdgeos: thx, I'll remove it.
[17:43] <tsdgeos> also don't understand * Unlike QDomDocument, this function assumes that the name of the id attribute is "id".
[17:44] <tsdgeos> elementById would be const?
[17:44] <marktaff> tsdgeos: QDomDocument always returns a null node because TT says they can't know which attribute is the id attribute
[17:45] <tsdgeos> so why not, rename to elementByAttributeName or something?
[17:46] <tsdgeos> currentNode and svgFilename should be const too
[17:47] <marktaff> tsdgeos: what do you mean (in code) by currentNode should be const?
[17:47] <tsdgeos> as styleProperty, nodeToSvg, nodeToByteArray, style, transform, styleProperties and transformMatrix
[17:48] <tsdgeos> marktaff: i mean that you must add
[17:48] <tsdgeos> "const"
[17:48] <tsdgeos> at the end of the declaration
[17:48] <tsdgeos> QString transform(); -> QString transform() const;
[17:48] <tsdgeos> also in the cpp
[17:48] <tsdgeos> that means "i'm not going to change this class when inside this function"
[17:49] <johann_ol> zhw: my god. He worked on ships too. He did some good stuffs. I need to harmonize them (especially the aircraft-carrier), but yes, you'll have your ships soon ;)
[17:49] <marktaff> k
[17:49] <tsdgeos> marktaff: you are a new C++ coder?
[17:50] <marktaff> tsdgeos: yes
[17:50] <tsdgeos> ok :-)
[17:50] <tsdgeos> it seems good removing that const thing
[17:51] <marktaff> ?
[17:51] <tsdgeos> err
[17:51] <tsdgeos> my english sucks
[17:51] <tsdgeos> i mean that the header is good
[17:51] <tsdgeos> if you fix the missing const i said
[17:51] <marktaff> k
[17:51] <tsdgeos> from the cpp
[17:51] <tsdgeos> return nodeToSvg().toLatin1();
[17:52] <tsdgeos> is nodeToSvg() guaranteed to be latin1() ?
[17:52] <zhw_> johann_ol: very good :)
[17:52] <tsdgeos> marktaff: also which problems did you have when moving to a d-pointer?
[17:53] <zhw_> johann_ol: I'm eager to sea the new graphics
[17:54] <marktaff> tsdgeos: k, I have the overly ratuitous use of @author removed
[17:55] <marktaff> tsdgeos: I am unsure if nodeToSvg is guaranteed to be latin1(). How can I be sure?
[17:56] <tsdgeos> well, what does nodeToSvg return?
[17:56] <tsdgeos> i mean it takes pieces from the input file?
[17:56] <marktaff> With the d-pointer, I have compile issues with "const"
[17:56] <marktaff> /home/kde-devel/kapp4/kgamesvgdocument.h: In member function KGameSvgDocument& KGameSvgDocument::operator=(const KGameSvgDocument&):/home/kde-devel/kapp4/kgamesvgdocument.h:102: error: non-static const member KGameSvgDocumentPrivate* const KGameSvgDocument::d, can't use default assignment operator
[17:56] <tsdgeos> and can that file contain non latin1 characters that would be carried ober to nodeToSvg?
[17:57] <marktaff> It does use the input svg file. I do not know if that file can contain non-latin1 chars. I'll have to grep the svg spec, I guess
[17:57] <tsdgeos> good
[17:57] <tsdgeos> well i have to go sleeping now
[17:58] <tsdgeos> will you be there tomorrow at european late-afternoon/night ?
[17:58] <marktaff> tsdgeos: night. Yes, I'll be here. I'll also keep hacking on your changes, and the d-pointer. thanks
[17:58] <tsdgeos> good luck :-)
[17:58] <tsdgeos> and good work!