1)> * debian/control: Do you really need to depend on postgresql-8.4? not> just postgresql?DONE.2)> * debian/copyright: There's a *bunch* of license files installed> in /usr/share/openbravo-erp/legal ... all of these need to be> discussed/mentioned/included in debian/copyrightDONE.3)> * debian/postinst:> - Regarding the series of echo's >> .profile ... a better way to do> this would be to install a file in say /usr/share/openbravo/> openbravorc,> and add just one line to the user's ~/.profile,> ". /usr/share/openbravo/openbravorc", which would source that file you> create; this would very much be in your interest as maintainer, such> that if you need to add a variable or change a variable definition, you> could do so in the /usr/share file, and all affected users would> automatically see the benefit. Otherwise, it's a nightmare trying to> muck about user's profiles on upgrade in the future.DONE.4)> - logging to /opt? Okay, so that's where openbravo wants to> install? At the very least, please put a symlink in /var/log/openbravo/> -> /opt/OpenbravoERP-*/logs/DONE.5)> - Lots of references to "2.50" ... I strongly recommend pulling that> out to a variable at the top of this script, or future work on this> package will be mistake-prone.DONE.6)> - cp -r /usr/share/openbravo-erp /opt/OpenbravoERP-2.50/ <--- Ugh.> Why not symlink, if it *must* be in /opt?DONE, won't be solved.7)> - In fact, a judicious use of good symlinks in debian/links could> really make this package "look and feel" more like a real Ubuntu> package.PENDING.8)> - PROP/VALUE/sed x 5: this would be much nicer and less error-prone> as a for-loopDONE.9)> - would be nice to group *all* of your chown's into one block, make> it much easier to figure out what's getting default ownerships changedPENDING.10)> - all of the psql lines could be lumped into one psql call to> improve readability and reduce code duplicationPENDING.11)> - all of the ln -s symlinks in postinst should be moved to a> debian/links file for better maintainability (symlinks installed in> postinst are not automatically removed on package removal)PENDING, same as 7).12)> - folder creation/ownerships: please put this in a loop tooDONE.13)> * debian/postrm:> - I don't understand the "db_input critical openbravo-erp/purge"> question on purge... if the user calls "apt-get purge", then they want> to purge. I suppose I could see it in the "remove" section, but I don't> understand it in the "purge" section. Also, you should put the "$RET" => "true" ... (purge stuff) code *right next* to the db_get. It's> confusing that there's other code in between. And what if something> else changes the value of RET in the mean time?PENDING.14)> - The hard "rm -rf" calls in postrm - The> packaging should *really* take care of this. The only stuff you should> ever really "rm -rf" in postrm would be cached files in /var (logs, lib,> cache). Why are there random files not getting removed> from /usr/share/openbravo-erp by the packaging? If that rm -rf is> necessary, something else is buggy.> * debian/templates: so the way a real Debian/Ubuntu package would work> with database data... 1) if the user uses "apt-get remove", the program> is uninstalled, but any created data (ie databases) are left untouched,> 2) if the user uses "apt-get purge", the program is uninstalled and all> database, logs, etc are also removed. There's no need for a debconf> question, IMHO.PENDING.15)> - embedded-javascript-library: These should probably be installed> in /usr/libDONE, won't be solved.16)> - init.d-script-missing-lsb-section: should be easy to fix, would be> good to havePENDING.17)> - script-calls-init-script-directly: It's odd to have init scripts> that call initscripts; you should really use the "service(8)" commandPENDING.18)> - script-not-executable: easy to solve, should be fixed -> ./usr/share/openbravo-erp/src-diagnostics/check-ob-perms.shDONE.