All pastes #1675247 Raw Edit

teuf

public text v1 · immutable
#1675247 ·published 2009-11-17 20:01 UTC
rendered paste body
commit 1d48f91e3d6c54c9b2ed2f371e5b01f87268e690Author: Christophe Fergeau <cfergeau@mandriva.com>Date:   Tue Nov 17 20:59:39 2009 +0100    add missing break; in switch statement        The 2nd missing break was harmless since it fell through the default: case    which has a break, but it makes things more robust if we were ever to add    new cases to this switch. The 1st missing break; was causing warnings in    valgrind since we ended up calling strdup on a memory zone not containing    a \0 character.diff --git a/src/plist.c b/src/plist.cindex eac7cc0..ed83e3c 100644--- a/src/plist.c+++ b/src/plist.c@@ -182,9 +182,11 @@ static void plist_copy_node(GNode * node, gpointer parent_node_ptr)         case PLIST_DATA:             newdata->buff = (uint8_t *) malloc(data->length);             memcpy(newdata->buff, data->buff, data->length);+            break;         case PLIST_KEY:         case PLIST_STRING:             newdata->strval = strdup((char *) data->strval);+            break;         default:             break;         }