[16:26] * jefferai wanted to just put in a big fat warning about that situation
[16:26] <leinir> Hmm... Big fat warning sounds good, for now at least ;) // FIXME! ? ;)
[16:26] <leinir> or even *gasp* // TODO: ;)
[16:27] <jefferai> I mean in the end it doesn't really matter, it's not going to be in 1.4.2
[16:27] <leinir> ok :)
[16:27] <jefferai> but for the majority of users, what I've already done will suffice
[16:27] <jefferai> leinir: here's a problem with lockfiles
[16:27] <jefferai> or, rather, per-directory
[16:27] <leinir> Yeah?
[16:27] <jefferai> say I'm running a scan on a network share
[16:27] <jefferai> so are you
[16:28] <jefferai> in fact, let's make it easier
[16:28] <jefferai> let's say I'm running a scan
[16:28] <jefferai> and no one else currently is
[16:28] <jefferai> I crash, and the lock files doesn't get removed
[16:28] <jefferai> now, let's say that you start running a scan
[16:28] <leinir> Yeah, lockfiles and crashes suck
[16:28] <jefferai> scanner hits the lockfile
[16:29] <jefferai> and doesn't know what to do...is it safe to delete? who knows? can't check to see if the other user is actually running or not
[16:29] <jefferai> does it pass those by? does it sit and wait? does it wait for a bit and then pass by? does it just not write to those files?
[16:30] <jefferai> then if you want to fix it you have to find any lockfiles currently around, somehow, and delete them
[16:30] <jefferai> really it's a huge pain
[16:30] <jefferai> you actually have the same problem with two people running amarok at once on the same computer with the same share
[16:30] <jefferai> can't detect that either...because you can't really look at the process list, unless you can assume they have KSysGuard and can hook into that
[16:30] <jefferai> which you can't
[16:30] <jefferai> :-(
[16:31] <jefferai> I think we should do a lockfile that works for a single user...and then have a warning stating that ATF tagging is not safe in a multiuser environment, and that only one user should have tag writing enabled
[16:32] <leinir> jefferai: Yeah... Big fat warning for that
[16:32] <jefferai> put it right in the Information window, which it says to read right next to the checkbox to enable ATF
[16:32] <jefferai> if you look at it, there are already BIG RED LETTERS saying PLEASE NOTE:
[16:32] <jefferai> I'll make it the first bullet point
[16:33] <jefferai> if they ignore the "see Information" and ignore the BIG LETTERS then they have no one to blame
[16:33] <jefferai> but themselves that is
[16:33] <jefferai> leinir: what do you think?
[16:33] <jefferai> think that will cover our asses well enough?
[16:35] <leinir> There's only so much that we can really do... It's turned off by default, big red letters with warnings (emphasising big, red is black to someone who's colourblind), and with a popup dialog with a warning in as well when you enable it... That's really all we can do
[16:48] <CIA-15> mkossick * r574027 amarok/trunk/extragear/multimedia/amarok/src/collectiondb.cpp:
[16:48] <CIA-15> copy&paste error--
[16:48] <CIA-15> BUG: 127503
[16:48] <CIA-15> BUG: 132453
[16:48] <jefferai> well, big = ALL CAPS
[16:48] <jefferai> we could make it blue :-)
[16:49] <leinir> No... Blue is information, not warning
[16:49] <jefferai> and we could put a popup up saying "Please ensure you have read the Information link"...eean will hate it, but it's better to be safe
[16:49] <jefferai> and yes, that's really all we can do
[16:49] <jefferai> if you share your music in a pool, it's up to you to make sure people abide by your rules
[16:49] <leinir> *nods* :)