[Wed Aug 2 2006] [23:04:34] <{ma}> what is vp3054-i2c
[Wed Aug 2 2006] [23:04:37] <mchehab> cx88-dvb is a mess... need to be redesigned.
[Wed Aug 2 2006] [23:04:52] <{ma}> the mess doesn' come from cx88-dvb
[Wed Aug 2 2006] [23:05:04] <mchehab> This specific device use two GPIO pins to create a separate I2C interface, via software.
[Wed Aug 2 2006] [23:05:07] <{ma}> but the way the entire driver is organized
[Wed Aug 2 2006] [23:05:54] <{ma}> well, i have specs to the actual VP(Vision Plus)-3054
[Wed Aug 2 2006] [23:05:58] <{ma}> a Twinhan device
[Wed Aug 2 2006] [23:06:13] <{ma}> as well the hardware
[Wed Aug 2 2006] [23:06:29] <mchehab> Nice!
[Wed Aug 2 2006] [23:06:40] <mchehab> is it a DVB-S device or DVB-T?
[Wed Aug 2 2006] [23:06:53] <mchehab> At the beginning, I was against adding this module.
[Wed Aug 2 2006] [23:06:56] <{ma}> never bothered to have a discussion because the entire thing looks very horrible to be worked on .. anythingb that i look at makes it look like more duplication again
[Wed Aug 2 2006] [23:07:02] <{ma}> Dvb-T + FM
[Wed Aug 2 2006] [23:07:16] <{ma}> It is not a DNTV card either
[Wed Aug 2 2006] [23:07:22] <{ma}> see the subsystem ID
[Wed Aug 2 2006] [23:08:01] <{ma}> It is a Twinhan card in fact. Anyway, i lookuing at how i can add in support for the VP-1027
[Wed Aug 2 2006] [23:08:14] <{ma}> DVB-S + DSS a small card
[Wed Aug 2 2006] [23:08:16] <mchehab> If you want, I may help you on it
[Wed Aug 2 2006] [23:09:16] <{ma}> i am working on that frontend. The frontend is a bit hard to be implemented in kernel
[Wed Aug 2 2006] [23:09:27] <{ma}> it doesn't work like the other frontends
[Wed Aug 2 2006] [23:09:37] <mchehab> I can work on integrating it to cx88 infrastructure
[Wed Aug 2 2006] [23:09:42] <{ma}> this was the frontend that caused the discussion for userspace drivers
[Wed Aug 2 2006] [23:10:00] <mchehab> ah
[Wed Aug 2 2006] [23:10:21] <{ma}> well, everyone agrees userspace is the right place
[Wed Aug 2 2006] [23:11:02] <{ma}> so, in that case i will need to work with the bridge interface as well, if i need to connect to the userspace driver
[Wed Aug 2 2006] [23:11:17] <{ma}> but the code in there looks real bad
[Wed Aug 2 2006] [23:11:33] <{ma}> i mean looks scatterd in fact
[Wed Aug 2 2006] [23:11:58] <mchehab> trust me: it isn't. It is just different from the concepts used on dvb code.
[Wed Aug 2 2006] [23:12:08] <mchehab> very easy to maintain
[Wed Aug 2 2006] [23:12:19] <{ma}> i mean i find it veryy hard to read the code
[Wed Aug 2 2006] [23:12:29] <mchehab> huh?
[Wed Aug 2 2006] [23:12:40] <{ma}> i mean functionality wise
[Wed Aug 2 2006] [23:12:40] <mchehab> seems very simple to me.
[Wed Aug 2 2006] [23:12:54] <{ma}> maybe because you spent too much time with it
[Wed Aug 2 2006] [23:13:02] <{ma}> :)
[Wed Aug 2 2006] [23:13:31] <mchehab> It looked simple to me the first time I touched it, to add PAL/M support.
[Wed Aug 2 2006] [23:14:16] <{ma}> the problem what i see with it is that analog /digital , everything is really a mixed up mees in there or something like that. At least what i felt on it
[Wed Aug 2 2006] [23:15:55] <{ma}> would it be okay , if i refactored some code at the PCI bridge level in there, while i am working on that device ?
[Wed Aug 2 2006] [23:16:19] <{ma}> or do i need to work on something completely from ground up ?
[Wed Aug 2 2006] [23:17:43] <mchehab> you should work with the existent code
[Wed Aug 2 2006] [23:17:48] <mchehab> not creating a newer one :)
[Wed Aug 2 2006] [23:18:07] <{ma}> but it looks like a jungle to me
[Wed Aug 2 2006] [23:18:25] <mchehab> Touching at bridge level will likely make some stuff to stop working
[Wed Aug 2 2006] [23:18:47] <{ma}> well, it will have to if devices have to work at userspace
[Wed Aug 2 2006] [23:19:10] <{ma}> otherwise all frontend with cx88 will remain broken later after a transition
[Wed Aug 2 2006] [23:19:38] <mchehab> you don't need to touch at PCI level. Just to write an userspace interface
[Wed Aug 2 2006] [23:20:13] <mchehab> This should be called only by cx88-dvb
[Wed Aug 2 2006] [23:20:16] <{ma}> the interface happens at the PCI bridge level
[Wed Aug 2 2006] [23:20:25] <{ma}> for all devices that 's how it is done
[Wed Aug 2 2006] [23:20:37] <{ma}> for the SAA7146, bt878 and others
[Wed Aug 2 2006] [23:22:42] <{ma}> well, i think you wouldn't want me to touch the cx88 code , i think
[Wed Aug 2 2006] [23:23:33] <mchehab> you can touch the code, not breaking it
[Wed Aug 2 2006] [23:24:15] <{ma}> well, i don't know what you mean breaking
[Wed Aug 2 2006] [23:24:28] <mchehab> creating an interface at PCI seems too affect all cx88 stuff
[Wed Aug 2 2006] [23:24:38] <mchehab> and not much modular
[Wed Aug 2 2006] [23:25:00] <mchehab> why do you need to interfere on cx8800 and cx8801 functions, for a cx8802 only stuff?
[Wed Aug 2 2006] [23:25:38] <{ma}> i just need only a minimal PCI interface.
[Wed Aug 2 2006] [23:25:46] <{ma}> i don't need all those devices
[Wed Aug 2 2006] [23:26:44] <mchehab> but analog stuff needs they
[Wed Aug 2 2006] [23:26:58] <mchehab> s/they/them/
[Wed Aug 2 2006] [23:27:35] <mchehab> the pci interface you need is at cx88-dvb
[Wed Aug 2 2006] [23:27:58] <mchehab> the other modules are for analog stuff
[Wed Aug 2 2006] [23:28:32] <{ma}> ok, i think then i need to take a look at cx88-dvb