Part of Slepp's ProjectsPastebinTURLImagebinFilebin
Feedback -- English French German Japanese
Create Upload Newest Tools Donate
Sign In | Create Account

Paste Description for yield_codec returns

Readd yield_codec but make it check the useful data. Should fix the PCM buffer dropping.

yield_codec returns
Monday, November 5th, 2007 at 8:44:16pm UTC 

  1. diff --git a/apps/buffering.c b/apps/buffering.c
  2. index dcc753e..9573ce4 100644
  3. --- a/apps/buffering.c
  4. +++ b/apps/buffering.c
  5. @@ -514,6 +514,34 @@ These functions are used by the buffering thread to manage buffer space.
  6.  */
  7.  
  8.  
  9. +static inline bool buffer_is_low(void)
  10. +{
  11. +    update_data_counters();
  12. +    return data_counters.useful < BUFFERING_CRITICAL_LEVEL;
  13. +}
  14. +
  15. +/* Yield to the codec thread for as long as possible if it is in need of data.
  16. +   Return true if the caller should break to let the buffering thread process
  17. +   new queue events */
  18. +static bool yield_codec(void)
  19. +{
  20. +    yield();
  21. +
  22. +    if (!queue_empty(&buffering_queue))
  23. +        return true;
  24. +
  25. +    while (pcmbuf_is_lowdata() && !buffer_is_low())
  26. +    {
  27. +        sleep(2);
  28. +        trigger_cpu_boost();
  29. +
  30. +        if (!queue_empty(&buffering_queue))
  31. +            return true;
  32. +    }
  33. +
  34. +    return false;
  35. +}
  36. +
  37.  /* Buffer data for the given handle.
  38.     Return whether or not the buffering should continue explicitly.  */
  39.  static bool buffer_handle(int handle_id)
  40. @@ -599,17 +627,8 @@ static bool buffer_handle(int handle_id)
  41.          yield();
  42.          /* If this is a large file, see if we need to breakor give the codec
  43.           * more time */
  44. -        if (h->type==TYPE_PACKET_AUDIO) {
  45. -            if (!queue_empty(&buffering_queue))
  46. -                break;
  47. -            if (pcmbuf_is_lowdata())
  48. -            {
  49. -                sleep(2);
  50. -                trigger_cpu_boost();
  51. -                if (!queue_empty(&buffering_queue))
  52. -                    break;
  53. -            }
  54. -        }
  55. +        if (h->type==TYPE_PACKET_AUDIO && yield_codec())
  56. +            break;
  57.      }
  58.  
  59.      if (h->filerem == 0) {

Update the Post

Either update this post and resubmit it with changes, or make a new post.

You may also comment on this post.

update paste below
details of the post (optional)

Note: Only the paste content is required, though the following information can be useful to others.

Save name / title?

(space separated, optional)



Please note that information posted here will expire by default in one month. If you do not want it to expire, please set the expiry time above. If it is set to expire, web search engines will not be allowed to index it prior to it expiring. Items that are not marked to expire will be indexable by search engines. Be careful with your passwords. All illegal activities will be reported and any information will be handed over to the authorities, so be good.

comments powered by Disqus
worth-right
worth-right